Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove allocations of lists before use #1989

Merged
merged 3 commits into from
Jun 23, 2024

Conversation

kradalby
Copy link
Collaborator

@kradalby kradalby commented Jun 20, 2024

Remove the allocation of lists before they are used.

kradalby added 2 commits June 20, 2024 13:27
Signed-off-by: Kristoffer Dalby <kristoffer@tailscale.com>
Signed-off-by: Kristoffer Dalby <kristoffer@tailscale.com>
@kradalby kradalby force-pushed the kradalby/reduce-allocs branch from fed012f to a2299e2 Compare June 20, 2024 11:28
Signed-off-by: Kristoffer Dalby <kristoffer@tailscale.com>
@kradalby kradalby changed the title reduce allocations Remove allocations of lists before use Jun 20, 2024
@kradalby kradalby marked this pull request as ready for review June 20, 2024 14:29
@kradalby kradalby requested a review from juanfont as a code owner June 20, 2024 14:29
Copy link
Collaborator

@ohdearaugustin ohdearaugustin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@kradalby kradalby merged commit 8f8f469 into juanfont:main Jun 23, 2024
103 checks passed
@kradalby kradalby deleted the kradalby/reduce-allocs branch June 23, 2024 20:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants