Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update Running.md #199

Merged
merged 3 commits into from
Nov 6, 2021
Merged

update Running.md #199

merged 3 commits into from
Nov 6, 2021

Conversation

rcursaru
Copy link
Contributor

clarify setup steps when using docker; use a single directory to hold all configuration for docker container

clarify setup steps; use a single directory to hold all configuration for docker container
@kradalby
Copy link
Collaborator

Hi, thanks for the contribution, it looks sensible.

I am wondering if we should split the whole docker setup into a separate file as the current configuration reads really confusing and is very obtuse and hard to keep track of.

Would you be up for actually splitting it up into a "running in docker".md ?

Neither I nor @juanfont use docker for headscale, and because of that we are not the people to maintain the docker configuration/running guide.

Copy link
Collaborator

@ohdearaugustin ohdearaugustin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

@kradalby kradalby merged commit 74f0d08 into juanfont:main Nov 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants