Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: configure some actions to be skipped for forks #2005

Merged
merged 2 commits into from
Dec 11, 2024

Conversation

vdovhanych
Copy link
Contributor

This is just a simple change.

This will configure some actions to be skipped for forks, as the actions that are changed here depend on the main repository or the configured secrets, so it makes no sense to run them for forks. This will also remove failed cron jobs from the forks, rest of the actions that don't depend on anything are left untouched.

@kradalby
Copy link
Collaborator

Sorry I completely missed this, can you rebase?

@vdovhanych vdovhanych force-pushed the only-run-action-main-repo branch from 0058a90 to c11f8e2 Compare December 11, 2024 14:36
@vdovhanych vdovhanych requested a review from nblock as a code owner December 11, 2024 14:36
@vdovhanych
Copy link
Contributor Author

I rebased it, but I'm not sure about the Docs deployment now. I see it's building it whenever you push to main, but I still feel that it is not really necessary for the forked repositories.
LMK, I can revert it there if you think it should still run on forks.

@nblock
Copy link
Collaborator

nblock commented Dec 11, 2024

I rebased it, but I'm not sure about the Docs deployment now. I see it's building it whenever you push to main, but I still feel that it is not really necessary for the forked repositories. LMK, I can revert it there if you think it should still run on forks.

You're right. Docs should probably only get built/pushed when either mkdocs.yml or something in docs/ changes.

But building and pushing should still work in a fork; I use this to render previews of proposed doc changes.

@vdovhanych vdovhanych force-pushed the only-run-action-main-repo branch from c11f8e2 to d580d32 Compare December 11, 2024 15:30
@vdovhanych
Copy link
Contributor Author

I rebased it, but I'm not sure about the Docs deployment now. I see it's building it whenever you push to main, but I still feel that it is not really necessary for the forked repositories. LMK, I can revert it there if you think it should still run on forks.

You're right. Docs should probably only get built/pushed when either mkdocs.yml or something in docs/ changes.

But building and pushing should still work in a fork; I use this to render previews of proposed doc changes.

Okay, let's keep it then. I removed the if condition from the docs and added that we should only run the build on push if the paths relevant to the docs change.

@kradalby
Copy link
Collaborator

Looks good to me, I'll let @nblock has the final say about the docs pipeline

@kradalby kradalby merged commit 697d80d into juanfont:main Dec 11, 2024
132 of 133 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants