feat: Add autogroup ACLs #2230
Draft
feat: Add autogroup ACLs #2230
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gabe565
force-pushed
the
add-autogroups
branch
from
5fb8a9c
to
e06f5a3
Compare
gabe565
force-pushed
the
add-autogroups
branch
from
523c419
to
fd038b9
Compare
|
Im on holiday so wont have time to take a look for a few weeks but wanted to just jump in and say that I have started work to redo the policy code, there is a draft pr, but its very draft pending many changes. I don't imagine I would add anything new to the policy as is, so this should be added on top of the new work. That said it might not be in the final state and it might be hard to do so yet. I do appreciate you picking this up, and would love to see it in when we get there. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have taken @vinhjaxt's autogroup implementation from #657 (comment), added some code improvements, fixed lint, and added tests. This is still a WIP, but so far it's working as intended.
Fixes #657