Ignoe derp.yaml, don't panic in Serve() #248
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@kradalby Do you know why the integration-test for the second pr fails? It adds only more logging. |
|
They are a bit flaky, I think they are a bit more resource hungry than actions wants to so they might get in an awkward state. Reruns usually helps... |
|
Makes sense. Thanks for the info! |
kradalby
reviewed
Dec 4, 2021
app.go
Outdated
| @@ -418,12 +418,12 @@ func (h *Headscale) Serve() error { | |||
|
|
|||
| err = h.ensureUnixSocketIsAbsent() | |||
| if err != nil { | |||
| panic(err) | |||
| return err | |||
There was a problem hiding this comment.
I think this is sensible,
But could you wrap these errors to give the user more context, when we are first at improving :)
So:
Suggested change
| return err | |
| return fmt.Errorf("description: %w", err) |
kradalby
reviewed
Dec 7, 2021
Co-authored-by: Kristoffer Dalby <kradalby@kradalby.no>
Co-authored-by: Kristoffer Dalby <kradalby@kradalby.no>
kradalby
approved these changes
Dec 7, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If there is no specifc reason to panic I think it's better to just return the error.