Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Do not setLastStateChangeToNow every expireEphemeralNodesWorker call #566

Merged
merged 2 commits into from
Apr 30, 2022
Merged

Do not setLastStateChangeToNow every expireEphemeralNodesWorker call #566

merged 2 commits into from
Apr 30, 2022

Conversation

juanfont
Copy link
Owner

@juanfont juanfont commented Apr 30, 2022 •
edited
Loading

setLastStateChangeToNow was being called everytime we run expireEphemeralNodesWorker, even if there are no nodes to expire.

  • updated CHANGELOG.md

@juanfont juanfont requested a review from kradalby as a code owner April 30, 2022 14:48
@juanfont juanfont changed the title Do not setLastStateChangeToNow every 5 seconds Do not setLastStateChangeToNow every expireEphemeralNodesWorker call Apr 30, 2022
@kradalby
Copy link
Collaborator

Oh lol yes, that explains a lot 🙈

@kradalby kradalby merged commit 96e2955 into main Apr 30, 2022
@kradalby kradalby deleted the fix-spurious-updates branch April 30, 2022 21:13
@juanfont juanfont mentioned this pull request Apr 30, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kradalby kradalby kradalby approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@juanfont @kradalby