Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix issue 635 #636

Merged
merged 1 commit into from
Jun 12, 2022
Merged

fix issue 635 #636

merged 1 commit into from
Jun 12, 2022

Conversation

huskyii
Copy link
Contributor

@huskyii huskyii commented Jun 12, 2022

  • read the CONTRIBUTING guidelines
  • raised a GitHub issue or discussed it on the projects chat beforehand
  • added unit tests
  • added integration tests
  • updated documentation if needed
  • updated CHANGELOG.md

@huskyii huskyii mentioned this pull request Jun 12, 2022
Closed
kradalby
kradalby approved these changes Jun 12, 2022
View reviewed changes
Copy link
Collaborator

@kradalby kradalby left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am happy about this fix, I think the #635 issue might be caused by this as the Release binaries seem to be correct.

@kradalby kradalby merged commit e0ef601 into juanfont:main Jun 12, 2022
@huskyii huskyii deleted the fix_issue635 branch June 12, 2022 12:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kradalby kradalby kradalby approved these changes

@juanfont juanfont Awaiting requested review from juanfont juanfont is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@huskyii @kradalby