Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ping db in health check #670

Merged
merged 2 commits into from
Jul 25, 2022
Merged

ping db in health check #670

merged 2 commits into from
Jul 25, 2022

Conversation

iSchluff
Copy link
Contributor

@iSchluff iSchluff commented Jul 6, 2022

Add basic db check to health endpoint

  • read the CONTRIBUTING guidelines
  • raised a GitHub issue or discussed it on the projects chat beforehand
  • added unit tests
  • added integration tests
  • updated documentation if needed
  • updated CHANGELOG.md

kradalby
kradalby reviewed Jul 10, 2022
View reviewed changes
Copy link
Collaborator

@kradalby kradalby left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall quite happy with this, seems reasonable, posted a couple of comments and would you mind fixing the lint errors?

api.go Show resolved Hide resolved
api.go Outdated Show resolved Hide resolved
@iSchluff iSchluff force-pushed the feature/db-health-check branch 2 times, most recently from 13dce2b to b2285db Compare July 12, 2022 20:53
@iSchluff iSchluff force-pushed the feature/db-health-check branch from b2285db to c6aaa37 Compare July 12, 2022 20:57
juanfont
juanfont approved these changes Jul 25, 2022
View reviewed changes
Copy link
Owner

@juanfont juanfont left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Thanks!

@juanfont juanfont merged commit 2d83c70 into juanfont:main Jul 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kradalby kradalby kradalby left review comments

@juanfont juanfont juanfont approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@iSchluff @kradalby @juanfont