Add ability to connect to PostgreSQL via unix socket #734
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ratsclub
changed the title
|
@vtrf would if be possible some details in https://github.com/juanfont/headscale/blob/main/config-example.yaml, to explain how to use this? I guess an extra line in line 116 clarifying that port should be blank for the socket, and host should be the path to it :) |
|
@juanfont Is this enough or should I go more in depth about the option? |
juanfont
reviewed
Aug 13, 2022
config-example.yaml
Outdated
| @@ -116,6 +116,9 @@ db_path: /var/lib/headscale/db.sqlite | |||
| # # Postgres config | |||
| # db_type: postgres | |||
| # db_host: localhost | |||
|
|
|||
| # This should be set when using a TCP connection, set it to '0' or keep it unset if | |||
| # connecting through a unix socket. | |||
There was a problem hiding this comment.
Suggested change
| # connecting through a unix socket. |
config-example.yaml
Outdated
| @@ -116,6 +116,9 @@ db_path: /var/lib/headscale/db.sqlite | |||
| # # Postgres config | |||
| # db_type: postgres | |||
| # db_host: localhost | |||
|
|
|||
| # This should be set when using a TCP connection, set it to '0' or keep it unset if | |||
There was a problem hiding this comment.
Suggested change
| # This should be set when using a TCP connection, set it to '0' or keep it unset if |
| @@ -116,6 +116,9 @@ db_path: /var/lib/headscale/db.sqlite | |||
| # # Postgres config | |||
There was a problem hiding this comment.
Suggested change
| # # Postgres config | |
| # # Postgres config | |
| # If using a Unix socket to connect to Postgres, set the socket path in the 'host' field and leave 'port' blank. |
|
@vtrf can you have a look at the suggestions? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is related to #733