Add integration tests for OIDC authentication #801
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kradalby
reviewed
Sep 21, 2022
| @@ -0,0 +1,22 @@ | |||
|
|
|||
| -----BEGIN CERTIFICATE----- | |||
There was a problem hiding this comment.
Can you create an issue to have all keys/certs used for testing generated at start? I dont like that we check them in, but its fine for this pr.
| joinWaitGroup sync.WaitGroup | ||
| } | ||
|
|
||
| func TestOIDCIntegrationTestSuite(t *testing.T) { |
There was a problem hiding this comment.
We really need to improve reusing code here, so much boilerplate 🥲
|
Note: This doesnt seem to run on macOS (or my Mac), but for the time being, that can be tackled as a separate issue. |
added 2 commits
September 21, 2022 15:01
kradalby
approved these changes
Sep 21, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds basic integration tests for our OIDC code.
For the time being they are pretty basic (just login in), but it is a start :)
We make use of https://github.com/oauth2-proxy/mockoidc for simulating a OIDC Identity Provider.