chore: re-enable linting rule to disallow the use of "any"

juanjoDiaz · Apr 29, 2024 · 92be585 · 92be585
1 parent 27d9420
commit 92be585
Show file tree

Hide file tree

Showing 21 changed files with 86 additions and 63 deletions.
diff --git a/.eslintrc.json b/.eslintrc.json
@@ -12,7 +12,6 @@
  "rules": {
  // Place to specify ESLint rules. Can be used to overwrite rules specified from the extended configs
  // e.g. "@typescript-eslint/explicit-function-return-type": "off",
- "@typescript-eslint/no-explicit-any": ["warn"],
  "@typescript-eslint/ban-ts-comment": ["error", { "ts-ignore": "allow-with-description" } ],
  "prettier/prettier": ["error", { "endOfLine": "auto" }]
  }

diff --git a/packages/node/dist/deno/jsonparser.ts b/packages/node/dist/deno/jsonparser.ts
@@ -39,10 +39,11 @@ export default class JSONParserTransform extends Transform {
  * @param {Function} done Called when the proceesing of the supplied chunk is done
  */
  override _transform(
+ // eslint-disable-next-line @typescript-eslint/no-explicit-any
  chunk: any,
  encoding: BufferEncoding,
  done: TransformCallback,
- ) {
+ ): void {
  try {
  this.jsonParser.write(chunk);
  done();
@@ -51,12 +52,12 @@ export default class JSONParserTransform extends Transform {
  }
  }
 
- override _final(done: any) {
+ override _final(callback: (error?: Error | null) => void): void {
  try {
  if (!this.jsonParser.isEnded) this.jsonParser.end();
- done();
+ callback();
  } catch (err: unknown) {
- done(err);
+ callback(err as Error);
  }
  }
 }
diff --git a/packages/node/dist/deno/tokenizer.ts b/packages/node/dist/deno/tokenizer.ts
@@ -41,10 +41,11 @@ export default class TokenizerTransform extends Transform {
  * @param {Function} done Called when the proceesing of the supplied chunk is done
  */
  override _transform(
+ // eslint-disable-next-line @typescript-eslint/no-explicit-any
  chunk: any,
  encoding: BufferEncoding,
  done: TransformCallback,
- ) {
+ ): void {
  try {
  this.tokenizer.write(chunk);
  done();
@@ -53,12 +54,12 @@ export default class TokenizerTransform extends Transform {
  }
  }
 
- override _final(done: any) {
+ override _final(callback: (error?: Error | null) => void): void {
  try {
  if (!this.tokenizer.isEnded) this.tokenizer.end();
- done();
+ callback();
  } catch (err: unknown) {
- done(err);
+ callback(err as Error);
  }
  }
 }
diff --git a/packages/node/dist/deno/tokenparser.ts b/packages/node/dist/deno/tokenparser.ts
@@ -39,10 +39,11 @@ export default class TokenParserTransform extends Transform {
  * @param {Function} done Called when the proceesing of the supplied chunk is done
  */
  override _transform(
+ // eslint-disable-next-line @typescript-eslint/no-explicit-any
  chunk: any,
  encoding: BufferEncoding,
  done: TransformCallback,
- ) {
+ ): void {
  try {
  this.tokenParser.write(chunk);
  done();
@@ -51,12 +52,12 @@ export default class TokenParserTransform extends Transform {
  }
  }
 
- override _final(done: any) {
+ override _final(callback: (error?: Error | null) => void): void {
  try {
  if (!this.tokenParser.isEnded) this.tokenParser.end();
- done();
+ callback();
  } catch (err: unknown) {
- done(err);
+ callback(err as Error);
  }
  }
 }
diff --git a/packages/node/src/jsonparser.ts b/packages/node/src/jsonparser.ts
@@ -39,10 +39,11 @@ export default class JSONParserTransform extends Transform {
  * @param {Function} done Called when the proceesing of the supplied chunk is done
  */
  override _transform(
+ // eslint-disable-next-line @typescript-eslint/no-explicit-any
  chunk: any,
  encoding: BufferEncoding,
  done: TransformCallback,
- ) {
+ ): void {
  try {
  this.jsonParser.write(chunk);
  done();
@@ -51,12 +52,12 @@ export default class JSONParserTransform extends Transform {
  }
  }
 
- override _final(done: any) {
+ override _final(callback: (error?: Error | null) => void): void {
  try {
  if (!this.jsonParser.isEnded) this.jsonParser.end();
- done();
+ callback();
  } catch (err: unknown) {
- done(err);
+ callback(err as Error);
  }
  }
 }
diff --git a/packages/node/src/tokenizer.ts b/packages/node/src/tokenizer.ts
@@ -41,10 +41,11 @@ export default class TokenizerTransform extends Transform {
  * @param {Function} done Called when the proceesing of the supplied chunk is done
  */
  override _transform(
+ // eslint-disable-next-line @typescript-eslint/no-explicit-any
  chunk: any,
  encoding: BufferEncoding,
  done: TransformCallback,
- ) {
+ ): void {
  try {
  this.tokenizer.write(chunk);
  done();
@@ -53,12 +54,12 @@ export default class TokenizerTransform extends Transform {
  }
  }
 
- override _final(done: any) {
+ override _final(callback: (error?: Error | null) => void): void {
  try {
  if (!this.tokenizer.isEnded) this.tokenizer.end();
- done();
+ callback();
  } catch (err: unknown) {
- done(err);
+ callback(err as Error);
  }
  }
 }
diff --git a/packages/node/src/tokenparser.ts b/packages/node/src/tokenparser.ts
@@ -39,10 +39,11 @@ export default class TokenParserTransform extends Transform {
  * @param {Function} done Called when the proceesing of the supplied chunk is done
  */
  override _transform(
+ // eslint-disable-next-line @typescript-eslint/no-explicit-any
  chunk: any,
  encoding: BufferEncoding,
  done: TransformCallback,
- ) {
+ ): void {
  try {
  this.tokenParser.write(chunk);
  done();
@@ -51,12 +52,12 @@ export default class TokenParserTransform extends Transform {
  }
  }
 
- override _final(done: any) {
+ override _final(callback: (error?: Error | null) => void): void {
  try {
  if (!this.tokenParser.isEnded) this.tokenParser.end();
- done();
+ callback();
  } catch (err: unknown) {
- done(err);
+ callback(err as Error);
  }
  }
 }
diff --git a/packages/node/test/selectors.ts b/packages/node/test/selectors.ts
@@ -76,8 +76,9 @@ describe("selectors", () => {
  try {
  new JSONParser({ paths });
  fail("Error expected on invalid selector");
- } catch (err: any) {
- expect(err.message).toEqual(expectedError);
+ } catch (err: unknown) {
+ expect(err).toBeInstanceOf(Error);
+ expect((err as Error).message).toEqual(expectedError);
  }
  });
  });

diff --git a/packages/node/test/separator.ts b/packages/node/test/separator.ts
@@ -59,8 +59,9 @@ describe("separator", () => {
  test(`separator: fail on invalid value`, async () => {
  try {
  await runJSONParserTest(new JSONParser({ separator: "abc" }), ["abe"]);
- } catch (err: any) {
- expect(err.message).toEqual(
+ } catch (err: unknown) {
+ expect(err).toBeInstanceOf(Error);
+ expect((err as Error).message).toEqual(
  'Unexpected "e" at position "2" in state SEPARATOR',
  );
  }
@@ -73,8 +74,11 @@ describe("separator", () => {
  { token: TokenType.TRUE, value: true },
  ]);
  fail("Error expected on invalid selector");
- } catch (err: any) {
- expect(err.message).toEqual("Unexpected TRUE (true) in state SEPARATOR");
+ } catch (err: unknown) {
+ expect(err).toBeInstanceOf(Error);
+ expect((err as Error).message).toEqual(
+ "Unexpected TRUE (true) in state SEPARATOR",
+ );
  }
  });
 
@@ -85,8 +89,9 @@ describe("separator", () => {
  { token: TokenType.SEPARATOR, value: "\r\n" },
  ]);
  fail("Error expected on invalid selector");
- } catch (err: any) {
- expect(err.message).toEqual(
+ } catch (err: unknown) {
+ expect(err).toBeInstanceOf(Error);
+ expect((err as Error).message).toEqual(
  'Unexpected SEPARATOR ("\\r\\n") in state SEPARATOR',
  );
  }

diff --git a/packages/node/test/utils/testRunner.ts b/packages/node/test/utils/testRunner.ts
@@ -8,7 +8,7 @@ import type { ParsedElementInfo } from "@streamparser/json/utils/types/parsedEle
 export type TestData = {
  value: string | string[] | Iterable<number>;
  paths?: string[];
- expected: any[];
+ expected: unknown[];
 };
 
 type ParseableData = string | Iterable<number>;

diff --git a/packages/plainjs/dist/deno/tokenizer.ts b/packages/plainjs/dist/deno/tokenizer.ts
@@ -771,8 +771,8 @@ export default class Tokenizer {
  }
  }
  }
- } catch (err: any) {
- this.error(err);
+ } catch (err: unknown) {
+ this.error(err as Error);
  }
  }
 

diff --git a/packages/plainjs/dist/deno/tokenparser.ts b/packages/plainjs/dist/deno/tokenparser.ts
@@ -349,9 +349,8 @@ export default class TokenParser {
  value,
  )}) in state ${TokenParserStateToString(this.state)}`,
  );
- // eslint-disable-next-line @typescript-eslint/no-explicit-any
- } catch (err: any) {
- this.error(err);
+ } catch (err: unknown) {
+ this.error(err as Error);
  }
  }
 

diff --git a/packages/plainjs/src/tokenizer.ts b/packages/plainjs/src/tokenizer.ts
@@ -771,8 +771,8 @@ export default class Tokenizer {
  }
  }
  }
- } catch (err: any) {
- this.error(err);
+ } catch (err: unknown) {
+ this.error(err as Error);
  }
  }
 

diff --git a/packages/plainjs/src/tokenparser.ts b/packages/plainjs/src/tokenparser.ts
@@ -349,9 +349,8 @@ export default class TokenParser {
  value,
  )}) in state ${TokenParserStateToString(this.state)}`,
  );
- // eslint-disable-next-line @typescript-eslint/no-explicit-any
- } catch (err: any) {
- this.error(err);
+ } catch (err: unknown) {
+ this.error(err as Error);
  }
  }
 

diff --git a/packages/plainjs/test/callbacks.ts b/packages/plainjs/test/callbacks.ts
@@ -51,7 +51,9 @@ describe("callback", () => {
 
  p.write('"test"');
  expect(onValueCb.mock.calls).toHaveLength(1);
- expect((onValueCb.mock.calls[0] as any)[0].value).toBe("test");
+ expect(
+ (onValueCb.mock.calls[0] as unknown as [{ value: string }])[0].value,
+ ).toBe("test");
  });
 
  test("should handle invalid input using the onError callback if set", () => {

diff --git a/packages/plainjs/test/selectors.ts b/packages/plainjs/test/selectors.ts
@@ -76,8 +76,9 @@ describe("selectors", () => {
  try {
  new JSONParser({ paths });
  fail("Error expected on invalid selector");
- } catch (err: any) {
- expect(err.message).toEqual(expectedError);
+ } catch (err: unknown) {
+ expect(err).toBeInstanceOf(Error);
+ expect((err as Error).message).toEqual(expectedError);
  }
  });
  });

diff --git a/packages/plainjs/test/separator.ts b/packages/plainjs/test/separator.ts
@@ -59,8 +59,9 @@ describe("separator", () => {
  test(`separator: fail on invalid value`, async () => {
  try {
  await runJSONParserTest(new JSONParser({ separator: "abc" }), ["abe"]);
- } catch (err: any) {
- expect(err.message).toEqual(
+ } catch (err: unknown) {
+ expect(err).toBeInstanceOf(Error);
+ expect((err as Error).message).toEqual(
  'Unexpected "e" at position "2" in state SEPARATOR',
  );
  }
@@ -73,8 +74,11 @@ describe("separator", () => {
  { token: TokenType.TRUE, value: true },
  ]);
  fail("Error expected on invalid selector");
- } catch (err: any) {
- expect(err.message).toEqual("Unexpected TRUE (true) in state SEPARATOR");
+ } catch (err: unknown) {
+ expect(err).toBeInstanceOf(Error);
+ expect((err as Error).message).toEqual(
+ "Unexpected TRUE (true) in state SEPARATOR",
+ );
  }
  });
 
@@ -85,8 +89,9 @@ describe("separator", () => {
  { token: TokenType.SEPARATOR, value: "\r\n" },
  ]);
  fail("Error expected on invalid selector");
- } catch (err: any) {
- expect(err.message).toEqual(
+ } catch (err: unknown) {
+ expect(err).toBeInstanceOf(Error);
+ expect((err as Error).message).toEqual(
  'Unexpected SEPARATOR ("\\r\\n") in state SEPARATOR',
  );
  }

diff --git a/packages/plainjs/test/utils/testRunner.ts b/packages/plainjs/test/utils/testRunner.ts
@@ -7,7 +7,7 @@ import { ParsedElementInfo } from "../../src/utils/types/parsedElementInfo.js";
 export type TestData = {
  value: string | string[] | Iterable<number>;
  paths?: string[];
- expected: any[];
+ expected: unknown[];
 };
 
 type ParseableData = string | Iterable<number>;

diff --git a/packages/whatwg/test/selectors.ts b/packages/whatwg/test/selectors.ts
@@ -76,8 +76,9 @@ describe("selectors", () => {
  try {
  new JSONParser({ paths });
  fail("Error expected on invalid selector");
- } catch (err: any) {
- expect(err.message).toEqual(expectedError);
+ } catch (err: unknown) {
+ expect(err).toBeInstanceOf(Error);
+ expect((err as Error).message).toEqual(expectedError);
  }
  });
  });