Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rewrite websockets #131

Merged
merged 5 commits into from
Mar 24, 2023
Merged

Rewrite websockets #131

merged 5 commits into from
Mar 24, 2023

Conversation

juanmc2005
Copy link
Owner

This PR addresses issue #113

Changelog

  • Re-implement WebSocketAudioSource from scratch using websocket-client and websocket-server instead of websockets
  • Add diart.client script to run a websocket client that sends audio (from the microphone or from a file) to a websocket server
  • Add diart.serve script to run a websocket server that receives audio from a websocket and sends responses in RTTM format
  • Move all diart.* CLI tools to diart.console (still accessible as e.g. diart.stream)
  • Add convenient diart.utils.encode_audio() and diart.utils.decode_audio() to send and receive audio between server and client
  • Include diart.serve and diart.client in websocket section of the README
  • Minor cleaning in diart.inference and diart.optim

The goal of diart.client in particular is to be able to test both the default and custom websocket servers easily

@juanmc2005 juanmc2005 added bug Something isn't working feature New feature or request labels Mar 13, 2023
@juanmc2005 juanmc2005 added this to the Version 0.7 milestone Mar 13, 2023
@juanmc2005 juanmc2005 merged commit e4fbef4 into develop Mar 24, 2023
@juanmc2005 juanmc2005 deleted the fix/ws branch March 24, 2023 10:40
@juanmc2005 juanmc2005 mentioned this pull request Mar 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working feature New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant