Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make pier clean unnecessary #65

Open
judah opened this issue Jan 26, 2018 · 0 comments
Open

Make pier clean unnecessary #65

judah opened this issue Jan 26, 2018 · 0 comments

Comments

@judah
Copy link
Owner

judah commented Jan 26, 2018

pier clean should only be needed when the source of pier gets recompiled. That seems like something we should just auto-detect.

One option: Use getExecutablePath to get a SHA of the current executable, and store it in the Shake database. (Or perhaps equivalently, need it along with ChangeModtimeAndDigest. In fact, making that a dependency of all other Persistent rules ought to be sufficient.

Also consider caching the build plan as a binary file in _pier.
judah added a commit that referenced this issue Jun 23, 2018
@judah
Remove the "clean" command.
cf47f79 
Cache the git revision in order to make it unnecessary.

Fixes #65.
judah added a commit that referenced this issue Jun 23, 2018
@judah
Remove the "clean" command.
97b0fec 
Cache the git revision in order to make it unnecessary.

Fixes #65.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@judah