Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The disabled form fields are not sent to the server #2

Closed
AmauryCarrade opened this issue Jan 26, 2014 · 8 comments
Closed

The disabled form fields are not sent to the server #2

AmauryCarrade opened this issue Jan 26, 2014 · 8 comments

Comments

@AmauryCarrade
Copy link

Hello.

Your plugin does not take into account the fact that the disabled form fields are not sent to the server.

You should not count them :) .

@judgej
Copy link
Owner

judgej commented Jan 26, 2014

Good point. I'll fix that.

I wonder if any properties of wrapping elements would also prevent the fields being sent? I know a display: none element can hide form elements, though they do still get sent, but I wonder if there are any other properties that can keep the fields out of submitted data?

@AmauryCarrade
Copy link
Author

Based on my knowledge, there is no CSS property able to interfer with the submitted data. Only attributes on fields (such as disabled, you should test readonly).

@judgej
Copy link
Owner

judgej commented Jan 26, 2014

Cool, thanks. I'll work on that during the week.

@judgej
Copy link
Owner

judgej commented Jan 27, 2014

Okay, my tax return did not take as long as I had thought, so I've (hopefully) fixed this now, and updated the demo so you can try it out by disabling form items.

I'm not sure what people use to formally regression test jQuery plugins, and I have not got anything formal in place, so hopefully a little clicking will be enough for now.

I accidentally put the wrong ticket number in. Release tag 1.1.0 should fix ticket #2 and not ticket #1. Please close the ticket if you are happy with the fix, or let me know if you find any problems or need the demo expanded to cover more test instances.

@AmauryCarrade
Copy link
Author

That's great for me.

You should merge these changes to master, too.

@AmauryCarrade
Copy link
Author

You can amend a commit with the git commit --amend command, to fix this wrong number.

@judgej
Copy link
Owner

judgej commented Jan 27, 2014

These changes should all be in master - that's the only branch I'm working on at the moment. I'll not amend the git commit message, as that looks like a world of pain - what's done is done. I'll add a history to the README though.

@judgej
Copy link
Owner

judgej commented Mar 2, 2014

In addition, form items without names are also not sent to the server. I have excluded those too.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants