Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨ lock refactor #64

Closed
wants to merge 1 commit into from
Closed

✨ lock refactor #64

wants to merge 1 commit into from

Conversation

juftin
Copy link
Owner

@juftin juftin commented Jan 30, 2024

This PR is a small refactor on the PipCompileLock class to have a single attribute, environment (PipCompileEnvironment), instead of many attributes. This gives the class full access to the parent PipCompileEnvironment class it's injected into.

@juftin juftin force-pushed the feat/lock_environment_refactor branch from c6f9f43 to a29f845 Compare February 1, 2024 03:14
Copy link

codecov bot commented Feb 1, 2024

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (4badcf9) 95.56% compared to head (99e798f) 95.53%.
Report is 1 commits behind head on main.

Files Patch % Lines
hatch_pip_compile/lock.py 94.11% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #64      +/-   ##
==========================================
- Coverage   95.56%   95.53%   -0.04%     
==========================================
  Files          16       16              
  Lines         857      851       -6     
  Branches      139      139              
==========================================
- Hits          819      813       -6     
  Misses         24       24              
  Partials       14       14              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@juftin juftin force-pushed the feat/lock_environment_refactor branch from a29f845 to 99e798f Compare February 21, 2024 03:20
@juftin juftin mentioned this pull request Feb 21, 2024
@juftin juftin closed this Feb 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant