-
Notifications
You must be signed in to change notification settings - Fork 67
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Handle unknown TPI response codes gracefully. (tornado) #45
Comments
With #49 (tornado) it will now log the unknown message and keep processing normally. Will add definition for the new zone bypass code, 616 shortly. |
Reopening - This isn't working as intended. I maybe misunderstanding things, but I'm guessing there is a structural problem with envisalink.py:handle_line(). All of the error handling in handle_line does a return which I think breaks things because that means the code never gets to the yield which causes the next read to occur. Actually maybe this should be a separate/new issue. |
AlarmServer should handle unknown TPI codes gracefully.
Currently with the feature/tornado branch, an unknown code generates a KeyError and then AlarmServer is broken but still running.
See #46 for an explanation of the 616 code which was added to TPI 1.07.
The text was updated successfully, but these errors were encountered: