Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"identifier" field missing from license #1139

Closed
fsasieta opened this issue Oct 15, 2024 · 2 comments · Fixed by #1140
Closed

"identifier" field missing from license #1139

fsasieta opened this issue Oct 15, 2024 · 2 comments · Fixed by #1140
Labels
enhancement New feature or request

Comments

@fsasieta
Copy link

Great crate!

One thing I noticed while I dabbled in updating to the 5.0.0, and my pre-commit hooks found (I use lin-openapi). The license object does not support specifying an identifier, see: https://spec.openapis.org/oas/latest.html#fixed-fields-2 . This errors on that particular check, but I did notice the License object defined here https://github.com/juhaku/utoipa/blob/master/utoipa/src/openapi/info.rs#L207-L218 did not contain it. I did a quick git search for any issues that were tracking it and couldn't find it, so decided to open this

@juhaku
Copy link
Owner

juhaku commented Oct 15, 2024

Oh, thanks for reporting, this must have been missed when updating to 3.1 from 3.0 as 3.0 does not have this field. Need to add this.

@juhaku juhaku moved this to Todo in utoipa kanban Oct 15, 2024
@juhaku juhaku added the enhancement New feature or request label Oct 15, 2024
juhaku added a commit that referenced this issue Oct 15, 2024
This commit adds `identifier` field to `Info` what was missing since
upgrading to OpenAPI 3.1.

Fixes #1139
juhaku added a commit that referenced this issue Oct 15, 2024
This commit adds `identifier` field to `Info` what was missing since
upgrading to OpenAPI 3.1.

Fixes #1139
@juhaku
Copy link
Owner

juhaku commented Oct 15, 2024

PR #1140 is on the way which adds identifier field. It can also be derived. But by default it is not going to be filled.

@juhaku juhaku moved this from Todo to In Progress in utoipa kanban Oct 15, 2024
@juhaku juhaku closed this as completed in ea498f3 Oct 15, 2024
@github-project-automation github-project-automation bot moved this from In Progress to Done in utoipa kanban Oct 15, 2024
@juhaku juhaku moved this from Done to Released in utoipa kanban Oct 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Status: Released
Development

Successfully merging a pull request may close this issue.

2 participants