Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Switch to oneOf instead allOf to handle nullable values (#1050) #1135

Merged
merged 1 commit into from
Oct 15, 2024
Merged

Switch to oneOf instead allOf to handle nullable values (#1050) #1135

merged 1 commit into from
Oct 15, 2024

Conversation

JMLX42
Copy link
Contributor

@JMLX42 JMLX42 commented Oct 15, 2024 •
edited by juhaku
Loading

fix for #1050

Closes #1050

@JMLX42 JMLX42 mentioned this pull request Oct 15, 2024
Closed
juhaku
juhaku approved these changes Oct 15, 2024
View reviewed changes
Copy link
Owner

@juhaku juhaku left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, if you add one line to the CHANGELOG.md of utoipa-gen would be perfect. Add it top of the Unreleased section and add sub title Changed.

@JMLX42
Copy link
Contributor Author

JMLX42 commented Oct 15, 2024

Looks great, if you add one line to the CHANGELOG.md of utoipa-gen would be perfect. Add it top of the Unreleased section and add sub title Changed.

@juhaku done

@juhaku
Copy link
Owner

juhaku commented Oct 15, 2024 •
edited
Loading

Great, seems like you have some automatic format for the md files, Can you revert the automatic format? Now there are bunch of unrelated changes. Though they could be formatted, but better for another PR.

EDIT: and it should be utoipa-gen/CHANGELOG.md 🙂

@JMLX42
Copy link
Contributor Author

JMLX42 commented Oct 15, 2024

Great, seems like you have some automatic format for the md files, Can you revert the automatic format? Now there are bunch of unrelated changes. Though they could be formatted, but better for another PR.

EDIT: and it should be utoipa-gen/CHANGELOG.md 🙂

@juhaku Wow my bad. Done and done!

juhaku
juhaku approved these changes Oct 15, 2024
View reviewed changes
Copy link
Owner

@juhaku juhaku left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Super 🎉

@juhaku juhaku merged commit de58f4d into juhaku:master Oct 15, 2024
11 checks passed
juhaku added a commit that referenced this pull request Oct 15, 2024
@juhaku
Change Option<T> compose to OneOfBuilder
ee2bd9d 
This commit change the `Option<T>` compose implementation from
`AllOfBuilder` to `OneOfBuilder`. This comes as follow up for #1135
which changed the `utoipa-gen` side nullable types from `allOf` to
`oneOf`.

Closes #1050 Closes #1135
@juhaku juhaku mentioned this pull request Oct 15, 2024
Merged
juhaku added a commit that referenced this pull request Oct 15, 2024
@juhaku
Change Option<T> compose to OneOfBuilder
d9a3c0f 
This commit change the `Option<T>` compose implementation from
`AllOfBuilder` to `OneOfBuilder`. This comes as follow up for #1135
which changed the `utoipa-gen` side nullable types from `allOf` to
`oneOf`.

Closes #1050 Closes #1135
juhaku added a commit that referenced this pull request Oct 15, 2024
@juhaku
Change Option<T> compose to OneOfBuilder
8022109 
This commit change the `Option<T>` compose implementation from
`AllOfBuilder` to `OneOfBuilder`. This comes as follow up for #1135
which changed the `utoipa-gen` side nullable types from `allOf` to
`oneOf`.

Closes #1050 Closes #1135
juhaku added a commit that referenced this pull request Oct 15, 2024
@juhaku
Change Option<T> compose to OneOfBuilder (#1141)
dd8c155 
This commit change the `Option<T>` compose implementation from
`AllOfBuilder` to `OneOfBuilder`. This comes as follow up for #1135
which changed the `utoipa-gen` side nullable types from `allOf` to
`oneOf`.

Closes #1050 Closes #1135
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@juhaku juhaku juhaku approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Redocly does not like nullable fields
2 participants
@JMLX42 @juhaku