Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Info::from_env() sets License::identifier #1233

Merged
merged 3 commits into from
Dec 13, 2024
Merged

Info::from_env() sets License::identifier #1233

merged 3 commits into from
Dec 13, 2024

Conversation

masnagam
Copy link
Contributor

This PR changes Info::from_env() to set info.license.identifier.

juhaku
juhaku requested changes Dec 12, 2024
View reviewed changes
Copy link
Owner

@juhaku juhaku left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, just missing CHANGELOG.md update. Add to Unreleased section new title of not exists Changed and then under that a a bullet point for the PR. Try to keep the order, newest first.

utoipa-gen/src/openapi/info.rs Show resolved Hide resolved
utoipa-gen/Cargo.toml Outdated Show resolved Hide resolved
@masnagam masnagam changed the title Info::from_env() sets info.license.identifier Info::from_env() sets License::identifier Dec 13, 2024
@masnagam
Copy link
Contributor Author

Looks good, just missing CHANGELOG.md update. Add to Unreleased section new title of not exists Changed and then under that a a bullet point for the PR. Try to keep the order, newest first.

updated in 5562641

juhaku
juhaku approved these changes Dec 13, 2024
View reviewed changes
Copy link
Owner

@juhaku juhaku left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, thanks for the patch 💯

@juhaku juhaku merged commit e7ddccb into juhaku:master Dec 13, 2024
12 checks passed
juhaku pushed a commit that referenced this pull request Dec 18, 2024
@masnagam @juhaku
Info::from_env() sets License::identifier (#1233)
4f09bc8 
`Info::from_env()` sets `info.license.identifier` along with `info.license.name`.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@juhaku juhaku juhaku approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@masnagam @juhaku