Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make sure to parse a comma token after the status in IntoResponses #630

Merged
merged 1 commit into from
May 29, 2023

Conversation

emanguy
Copy link
Contributor

@emanguy emanguy commented May 29, 2023

This fixes the issue I filed earlier today: #629

Just adds a little logic to the DeriveIntoResponsesValue implementation that makes it consume a comma after consuming the status attribute if there is more to consume.

Fixes #629

Copy link
Owner

@juhaku juhaku left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good 💯

@juhaku juhaku merged commit 16bec9d into juhaku:master May 29, 2023
@emanguy emanguy deleted the fix-missing-comma-in-intoresponses branch May 29, 2023 23:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

response() attribute for IntoResponses macro does not separate arguments with commas on enum variants
2 participants