Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Step 4 to provide External linkage #112

Merged
merged 1 commit into from
May 20, 2022

Conversation

blucas-accela
Copy link
Contributor

I've added some steps to create that external connectivity. Please review, test, and merge.

@J12934
Copy link
Member

J12934 commented Apr 21, 2022

Hi 👋

Thank you for the PR 🙏
Do you know if the Azure LoadBalancer support handling of certificates to secure the endpoint?
So that we can easily expand the guide to show users how to configure https for the endpoint.

@J12934 J12934 added documentation Improvements or additions to documentation enhancement New feature or request labels Apr 21, 2022
@blucas-accela
Copy link
Contributor Author

I don't know if it does but if it is like other Azure Load Balancers, I believe the answer is "no." For that, you'd probably want their App Gateway integration which does support TLS offloading.

@J12934 J12934 merged commit cb0d81c into juice-shop:master May 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants