Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Use more modern version and remove unsupported auto #180

Merged
merged 1 commit into from
Sep 23, 2023

Conversation

wurstbrot
Copy link
Member

@wurstbrot wurstbrot commented Sep 22, 2023

version 21 is not supported.
With version 23, auto is not supported anymore

@J12934 J12934 merged commit ef1b67c into juice-shop:main Sep 23, 2023
3 checks passed
@J12934
Copy link
Member

J12934 commented Sep 23, 2023

@wurstbrot do you know if we can just leave out the version here?
Does it then just automatically pick a supported version?

@wurstbrot
Copy link
Member Author

@wurstbrot do you know if we can just leave out the version here? Does it then just automatically pick a supported version?

@J12934 I just startet it without and it picked up 1.25 (latest I think).

@J12934
Copy link
Member

J12934 commented Sep 24, 2023

perfect thank you, I then just removed the number from there. I guess there no point in updating it all the time.

@wurstbrot wurstbrot deleted the patch-1 branch January 19, 2024 07:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants