Automatic cleanup of JuiceShop on uninstall #29
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Referencing `metadata.uid` isn't enought as this can only access values from the pod, not the deployment.
This isn't true anymore as deleting the JuiceBalancer will automatically cleanup related instances.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
JuiceShop Instances are now properly linked to the JuiceBalancer they were created by.
This is done by using the kubernetes ownerReferences: https://kubernetes.io/docs/concepts/workloads/controllers/garbage-collection/
When the Stack gets uninstalled all JuiceShop Instances and Services are automatically cleaned up by kubernetes.
This has the nice side effect that the awesome tool kubectl-tree now works properly:
