Update github actions

juicebox-systems · Aug 14, 2024 · fe40986 · fe40986
1 parent 4fa7a20
commit fe40986
Show file tree

Hide file tree

Showing 9 changed files with 36 additions and 259 deletions.
diff --git a/.github/actions/software-realm/action.yaml b/.github/actions/software-realm/action.yaml
@@ -5,8 +5,6 @@ inputs:
   start-realm-count:
     description: How many jb-sw-realm should be started after the binary is installed. By default, no realms are started.
     default: "0"
-  token:
-    description: The authorization token for accessing private git repos.
   ref:
     description: The ref for the software realm repo
 outputs:
@@ -23,7 +21,6 @@ runs:
       uses: actions/checkout@v3
       with:
         repository: 'juicebox-systems/juicebox-software-realm'
-        token: ${{ inputs.token }}
         path: 'juicebox-software-realm'
         ref: ${{ inputs.ref }}
 

diff --git a/.github/workflows/android.yaml b/.github/workflows/android.yaml
@@ -25,7 +25,6 @@ jobs:
     - uses: actions/checkout@v3
       with:
         submodules: recursive
-        token: ${{ secrets.ACCESS_TOKEN }}
 
     - name: Set up JDK 11
       uses: actions/setup-java@v3

diff --git a/.github/workflows/audit.yaml b/.github/workflows/audit.yaml
@@ -13,5 +13,3 @@ jobs:
     steps:
       - uses: actions/checkout@v3
       - uses: rustsec/audit-check@v1.4.1
-        with:
-          token: ${{ secrets.GITHUB_TOKEN }}
diff --git a/.github/workflows/demos.yaml b/.github/workflows/demos.yaml
@@ -39,7 +39,6 @@ jobs:
         uses: ./.github/actions/software-realm
         with:
           start-realm-count: 25
-          token: ${{ secrets.ACCESS_TOKEN }}
 
       - name: Run Rust Demo
         run: target/debug/demo --configuration ${{ steps.software-realm.outputs.configuration }} --auth-tokens ${{ steps.software-realm.outputs.auth-tokens }}
@@ -80,7 +79,6 @@ jobs:
         uses: ./.github/actions/software-realm
         with:
           start-realm-count: 25
-          token: ${{ secrets.ACCESS_TOKEN }}
 
       - name: Run Swift Demo
         run: swift/demo/.build/debug/demo -c ${{ steps.software-realm.outputs.configuration }} -a ${{ steps.software-realm.outputs.auth-tokens }}
@@ -124,7 +122,6 @@ jobs:
         uses: ./.github/actions/software-realm
         with:
           start-realm-count: 25
-          token: ${{ secrets.ACCESS_TOKEN }}
 
       - name: Run WASM Demo
         run: javascript/demo/demo.ts -c ${{ steps.software-realm.outputs.configuration }} -a ${{ steps.software-realm.outputs.auth-tokens }}
diff --git a/.github/workflows/documentation.yaml b/.github/workflows/documentation.yaml
diff --git a/.github/workflows/main.yaml b/.github/workflows/main.yaml
@@ -68,6 +68,10 @@ jobs:
     steps:
       - uses: actions/checkout@v3
 
+      - name: Install Swiftlint
+        run: |
+          brew install swiftlint
+
       - name: Lint
         run: swiftlint lint --strict --reporter github-actions-logging
         working-directory: swift
@@ -134,8 +138,6 @@ jobs:
 
       - name: Software Realm
         uses: ./.github/actions/software-realm
-        with:
-          token: ${{ secrets.ACCESS_TOKEN }}
 
       - name: Run software realm integration tests
         uses: actions-rs/cargo@v1

diff --git a/.github/workflows/publish.yaml b/.github/workflows/publish.yaml
@@ -17,7 +17,6 @@ jobs:
       - uses: actions/checkout@v3
         with:
           submodules: recursive
-          token: ${{ secrets.ACCESS_TOKEN }}
 
       - name: Build juicebox_sdk_jni
         run: |
@@ -96,7 +95,6 @@ jobs:
       - uses: actions/checkout@v3
         with:
           submodules: recursive
-          token: ${{ secrets.ACCESS_TOKEN }}
 
       - name: Build juicebox_sdk_ffi
         run: |

diff --git a/swift/Sources/JuiceboxSdk/Client.swift b/swift/Sources/JuiceboxSdk/Client.swift
@@ -258,7 +258,7 @@ let httpSend: JuiceboxHttpSendFn = { context, requestPointer, responseCallback i
     }.resume()
 }
 
-let authTokenGet: JuiceboxAuthTokenGetFn = { context, contextId, realmId, callback -> Void in
+let authTokenGet: JuiceboxAuthTokenGetFn = { context, contextId, realmId, callback in
     guard let callback = callback, let realmId = realmId else { return }
 
     guard let fetchFn = Client.fetchAuthTokenCallback else {