cmd/clone: set the attr should be done after checking permissions (#4745

)
juicedata · Jun 19, 2024 · 790db41 · 790db41
1 parent f902cc6
commit 790db41
Showing 1 changed file with 6 additions and 4 deletions.
diff --git a/pkg/meta/sql.go b/pkg/meta/sql.go
@@ -3907,6 +3907,12 @@ func (m *dbMeta) doCloneEntry(ctx Context, srcIno Ino, parent Ino, name string,
  n.Inode = ino
  n.Parent = parent
  now := time.Now()
+
+ m.parseAttr(&n, attr)
+ if eno := m.Access(ctx, srcIno, MODE_MASK_R, attr); eno != 0 {
+ return eno
+ }
+
  if cmode&CLONE_MODE_PRESERVE_ATTR == 0 {
  n.Uid = ctx.Uid()
  n.Gid = ctx.Gid()
@@ -3922,10 +3928,6 @@ func (m *dbMeta) doCloneEntry(ctx Context, srcIno Ino, parent Ino, name string,
  if n.Type == TypeFile && n.Nlink > 1 {
  n.Nlink = 1
  }
- m.parseAttr(&n, attr)
- if eno := m.Access(ctx, srcIno, MODE_MASK_R, attr); eno != 0 {
- return eno
- }
 
  if top {
  var pattr Attr