enhance: check for link (#4625)

Signed-off-by: jiefenghuang <jiefeng@juicedata.io>
juicedata · Jun 19, 2024 · c42509b · c42509b
1 parent a4a58f1
commit c42509b
Show file tree

Hide file tree

Showing 4 changed files with 6 additions and 3 deletions.
diff --git a/pkg/meta/base.go b/pkg/meta/base.go
@@ -1397,6 +1397,9 @@ func (m *baseMeta) Link(ctx Context, inode, parent Ino, name string, attr *Attr)
  if name == "" {
  return syscall.ENOENT
  }
+ if name == "." || name == ".." {
+ return syscall.EEXIST
+ }
 
  defer m.timeit("Link", time.Now())
  if attr == nil {

diff --git a/pkg/meta/redis.go b/pkg/meta/redis.go
@@ -1896,7 +1896,7 @@ func (m *redisMeta) doLink(ctx Context, inode, parent Ino, name string, attr *At
  if pattr.Parent > TrashInode {
  return syscall.ENOENT
  }
- if st := m.Access(ctx, parent, MODE_MASK_W, &pattr); st != 0 {
+ if st := m.Access(ctx, parent, MODE_MASK_W|MODE_MASK_X, &pattr); st != 0 {
  return st
  }
  if pattr.Flags&FlagImmutable != 0 {

diff --git a/pkg/meta/sql.go b/pkg/meta/sql.go
@@ -1954,7 +1954,7 @@ func (m *dbMeta) doLink(ctx Context, inode, parent Ino, name string, attr *Attr)
  }
  var pattr Attr
  m.parseAttr(&pn, &pattr)
- if st := m.Access(ctx, parent, MODE_MASK_W, &pattr); st != 0 {
+ if st := m.Access(ctx, parent, MODE_MASK_W|MODE_MASK_X, &pattr); st != 0 {
  return st
  }
  if pn.Flags&FlagImmutable != 0 {

diff --git a/pkg/meta/tkv.go b/pkg/meta/tkv.go
@@ -1729,7 +1729,7 @@ func (m *kvMeta) doLink(ctx Context, inode, parent Ino, name string, attr *Attr)
  if pattr.Parent > TrashInode {
  return syscall.ENOENT
  }
- if st := m.Access(ctx, parent, MODE_MASK_W, &pattr); st != 0 {
+ if st := m.Access(ctx, parent, MODE_MASK_W|MODE_MASK_X, &pattr); st != 0 {
  return st
  }
  if pattr.Flags&FlagImmutable != 0 {