Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix minio with sync #1055

Merged
merged 2 commits into from
Nov 25, 2021
Merged

fix minio with sync #1055

merged 2 commits into from
Nov 25, 2021

Conversation

davies
Copy link
Contributor

@davies davies commented Nov 24, 2021

When a subpath is specified with Minio, juice sync fails with 403.

TODO: we should enable the unit test with Minio

@codecov-commenter
Copy link

Codecov Report

Merging #1055 (f9853e5) into main (ec80f83) will decrease coverage by 0.57%.
The diff coverage is 0.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##               main    #1055      +/-   ##
============================================
- Coverage     46.15%   45.58%   -0.58%     
  Complexity      149      149              
============================================
  Files           146      147       +1     
  Lines         23782    23296     -486     
  Branches        422      422              
============================================
- Hits          10977    10619     -358     
+ Misses        11463    11385      -78     
+ Partials       1342     1292      -50     
Impacted Files Coverage Δ
pkg/object/minio.go 5.88% <0.00%> (+0.16%) ⬆️
pkg/meta/sql.go 68.68% <0.00%> (-1.22%) ⬇️
pkg/vfs/writer.go 78.64% <0.00%> (-1.02%) ⬇️
pkg/vfs/handle.go 85.71% <0.00%> (-0.85%) ⬇️
pkg/chunk/cached_store.go 55.55% <0.00%> (-0.74%) ⬇️
pkg/meta/redis.go 72.24% <0.00%> (-0.66%) ⬇️
pkg/meta/tkv.go 76.92% <0.00%> (-0.33%) ⬇️
pkg/meta/base.go 84.19% <0.00%> (ø)
pkg/utils/utils.go 89.04% <0.00%> (+2.60%) ⬆️
pkg/meta/utils.go 73.00% <0.00%> (+5.52%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ec80f83...f9853e5. Read the comment docs.

@axolo-co axolo-co bot requested a review from SandyXSD November 24, 2021 12:22
@davies davies merged commit e5ba472 into main Nov 25, 2021
@davies davies deleted the fix_minio branch November 25, 2021 02:34
davies added a commit that referenced this pull request Dec 6, 2021
* fix minio with sync

* with Minio with subpath
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants