Fix potential metadata corrupt in Redis caused by gc #1110
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
gc
command will scan all the entries and inodes to find out dangling (not used by any entry) inodes. The scanning of entries is not atomic, so we ignore all the inodes (checking the atime) created in last hour. There is still a chance that a inode was renamed and both the old name and new name are missed from the scanning, then the inode will be identify as dangling and deleted.This PR change it to check the Ctime of inode, ignore the inodes that was created or renamed within a hour.