Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: permission mode of new node with minimum default acl #4676

Merged
merged 3 commits into from
Apr 9, 2024

Conversation

jiefenghuang
Copy link
Contributor

close #4663

Signed-off-by: jiefenghuang <jiefeng@juicedata.io>
Copy link

codecov bot commented Apr 9, 2024

Codecov Report

Attention: Patch coverage is 0% with 3 lines in your changes are missing coverage. Please review.

Project coverage is 30.91%. Comparing base (b281022) to head (3b40221).
Report is 6 commits behind head on main.

❗ Current head 3b40221 differs from pull request most recent head 9d29216. Consider uploading reports for the commit 9d29216 to get more accurate results

Files Patch % Lines
pkg/meta/redis.go 0.00% 1 Missing ⚠️
pkg/meta/sql.go 0.00% 1 Missing ⚠️
pkg/meta/tkv.go 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4676      +/-   ##
==========================================
+ Coverage   24.97%   30.91%   +5.93%     
==========================================
  Files          25      158     +133     
  Lines       15994    42601   +26607     
==========================================
+ Hits         3995    13171    +9176     
- Misses      11512    27761   +16249     
- Partials      487     1669    +1182     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Signed-off-by: jiefenghuang <jiefeng@juicedata.io>
Signed-off-by: jiefenghuang <jiefeng@juicedata.io>
@jiefenghuang jiefenghuang marked this pull request as ready for review April 9, 2024 09:56
@davies davies merged commit 12e64a9 into juicedata:main Apr 9, 2024
32 checks passed
@jiefenghuang jiefenghuang deleted the fix/acl branch April 15, 2024 07:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

mode of mkdir incorrect after setacl.
2 participants