fix: JfsObjects.CompleteMultipartUpload #4893
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
6 tasks
zhijian-pro
approved these changes
May 24, 2024
zhijian-pro
reviewed
May 24, 2024
SandyXSD
pushed a commit
that referenced
this pull request
Jun 19, 2024
Co-authored-by: zhijian <djx@juicedata.io>
SandyXSD
pushed a commit
that referenced
this pull request
Jun 20, 2024
Co-authored-by: zhijian <djx@juicedata.io>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Increased max size of part to 5Gb in CompleteMultipartUpload
Motivation and Context
I've caught bug when tested server side copy with rclone. Rclone has default copy cutoff 4.656Gi. During CompleteMultipartUpload gateway ignores size of parts and doesn't consider globalMaxPartSize (5GiB) and copies 1Gb max of each part.