stats cmd should be robust enough to handle metrics with multiple labels #4941
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When objects sink to cold storage, we will have multiple
storage_class
labels inobject_request_data_bytes
metric, which causes the stats cmd shows less object bandwidth than actual.The stats cmd should be robust to this situation - it's counter-intuitive for a newcomer to realize that adding a new label to those metrics will cause the stats cmd to function incorrectly.