Add metrics for current cache/object readers #5202
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Changxin Miao <miaochangxin@step.ai>
davies
reviewed
Sep 29, 2024
| Help: "number of storage readers", | ||
| ConstLabels: prometheus.Labels{"storage": "object"}, | ||
| }, func() float64 { | ||
| return float64(store.objectReaders.Load()) |
There was a problem hiding this comment.
We can add a limit for concurrent GET, and know the actual concurrency using that.
There was a problem hiding this comment.
Currently we don't have that limitation right?
davies
reviewed
Sep 29, 2024
| Help: "number of storage readers", | ||
| ConstLabels: prometheus.Labels{"storage": "cache"}, | ||
| }, func() float64 { | ||
| return float64(store.cacheReaders.Load()) |
There was a problem hiding this comment.
We can know the concurrent IO from dcState
There was a problem hiding this comment.
concurrency counter is only updated in unstableDC implementation. To track concurrency in other states, I have to move it to baseDC?
|
We usually use the rate of object_request_durations_histogram_seconds as the metric of concurrency, no new metric needed. Same to other operations or requests. |
|
OK, closing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Align with
object_request_uploading, so we know the pressure we are exposing to the backend storage.