Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mount: support setting readahead to 0 #5704

Merged
merged 1 commit into from
Mar 18, 2025
Merged

mount: support setting readahead to 0 #5704

merged 1 commit into from
Mar 18, 2025

Conversation

jiefenghuang
Copy link
Contributor

@jiefenghuang jiefenghuang commented Feb 28, 2025

ref #5547
close #5224

@jiefenghuang jiefenghuang requested a review from SandyXSD March 7, 2025 04:42
@SandyXSD SandyXSD requested review from davies and removed request for SandyXSD March 7, 2025 05:54
@SandyXSD SandyXSD marked this pull request as draft March 7, 2025 06:37
Signed-off-by: jiefenghuang <jiefeng@juicedata.io>
Copy link

codecov bot commented Mar 18, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 21.46%. Comparing base (c6b9e0d) to head (b1e5776).
Report is 23 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff             @@
##             main    #5704       +/-   ##
===========================================
- Coverage   54.68%   21.46%   -33.23%     
===========================================
  Files         166       29      -137     
  Lines       48743    19342    -29401     
===========================================
- Hits        26657     4151    -22506     
+ Misses      19147    14694     -4453     
+ Partials     2939      497     -2442     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@jiefenghuang jiefenghuang marked this pull request as ready for review March 18, 2025 03:09
@jiefenghuang jiefenghuang changed the title mount: change readahead unit to block mount: support setting readahead to 0 Mar 18, 2025
@jiefenghuang jiefenghuang requested a review from SandyXSD March 18, 2025 03:10
@davies davies merged commit e81aba6 into main Mar 18, 2025
35 checks passed
@davies davies deleted the flag-readahead branch March 18, 2025 05:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Make max-readahead configurable to enhance read performance
2 participants