Skip to content

Fix loadedCallbackPending logic to properly prevent frame invalidation during Unity player creation #1020

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fix loadedCallbackPending logic to properly prevent frame invalidation during Unity player creation #1020

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion ...oid/src/main/kotlin/com/xraph/plugin/flutter_unity_widget/FlutterUnityWidgetController.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -285,10 +285,12 @@ class FlutterUnityWidgetController(
private fun createPlayer() {
try {
if (UnityPlayerUtils.activity != null) {
loadedCallbackPending = true
UnityPlayerUtils.createUnityPlayer( this, object : OnCreateUnityViewCallback {
override fun onReady() {
// attach unity to controller
attachToView()
loadedCallbackPending = false

if (methodChannelResult != null) {
methodChannelResult!!.success(true)
Expand All @@ -298,6 +300,7 @@ class FlutterUnityWidgetController(
})
}
} catch (e: Exception) {
loadedCallbackPending = false
if (methodChannelResult != null) {
methodChannelResult!!.error("FLUTTER_UNITY_WIDGET", e.message, e)
methodChannelResult!!.success(false)
Expand Down Expand Up @@ -372,7 +375,6 @@ class FlutterUnityWidgetController(
return
}

loadedCallbackPending = false
postFrameCallback {
postFrameCallback {
view.invalidate()
Expand Down