Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[feat global_unity_controller] Update examples to null safety #737

Conversation

timbotimbo
Copy link
Collaborator

@timbotimbo timbotimbo commented Dec 24, 2022

Note

This is the same change as #732, but based on the global_unity_controller feature branch #733 as requested.
In that branch only api_screen.dart was already updated for the new API changes, so the other pages might still be outdated.

Description

The example code can't simply be pasted into a modern flutter project. It will show errors, mainly due to null-safety changes.
Given that the plugin supports null-safety from version 4.2.0 (18 months ago), it's safe to update the example.

The last commit is a small cleanup by following most suggestions of flutter_lints.

Type of Change

  • ✨ New feature (non-breaking change which adds functionality)
  • 🛠️ Bug fix (non-breaking change which fixes an issue)
  • ❌ Breaking change (fix or feature that would cause existing functionality to change)
  • 🧹 Code refactor
  • ✅ Build configuration change
  • 📝 Documentation
  • 🗑️ Chore

@timbotimbo timbotimbo mentioned this pull request Dec 24, 2022
7 tasks
@juicycleff juicycleff merged commit b233e52 into juicycleff:feat/global_unity_controller Dec 30, 2022
@timbotimbo timbotimbo deleted the global_controller_nullsafe branch January 17, 2023 21:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants