Prefix assume & assert definitions to prevent name clashes #70
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi @juj
We use MathGeoLib alongside other libraries and recently suffered unexpected compilation errors whose cause took a bit of time to track. In the end, we found out it was actually due to MathGeoLib redefining
assume
, which broke other dependencies also using this common name (for instance, fmt: https://github.com/fmtlib/fmt/blob/739055ae7b08f8d5dffee9552334ede92e50b17b/include/fmt/format.h#L354)This commit prefixes
assume
(as well asassert
andmathassert
for consistency) with "mgl_" to prevent that issue.If you prefer, I could use another prefix.