Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prefix assume & assert definitions to prevent name clashes #70

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

merwaaan
Copy link
Contributor

Hi @juj

We use MathGeoLib alongside other libraries and recently suffered unexpected compilation errors whose cause took a bit of time to track. In the end, we found out it was actually due to MathGeoLib redefining assume, which broke other dependencies also using this common name (for instance, fmt: https://github.com/fmtlib/fmt/blob/739055ae7b08f8d5dffee9552334ede92e50b17b/include/fmt/format.h#L354)

This commit prefixes assume (as well as assert and mathassert for consistency) with "mgl_" to prevent that issue.
If you prefer, I could use another prefix.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant