Modifies tracing to removed Cause based errors. #63
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This work changes tracing to now offer a new Locationer based error into stack. Printing an Error stack now will provide a line for each error in the stack by calling Unwrap() till no more errors are found. This fundementally changes the output produced by ErrorStack to now just include each call to Trace() but also contain the value of the error at each Trace() call. This PR also provides a new documentation worked example.
hpidcock
approved these changes
Oct 23, 2023
|
/merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This work changes tracing to now offer a new Locationer based error into stack. Printing an Error stack now will provide a line for each error in the stack by calling Unwrap() till no more errors are found.
This fundementally changes the output produced by ErrorStack to now just include each call to Trace() but also contain the value of the error at each Trace() call.
This PR also provides a new documentation worked example.
JUJU-4699