chore: merge 3.5 into 3.6 #82
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
feat: add 24.04 as a supported Ubuntu base
chore: merge 3.4 into 3.5
This required in order to build the binary wheel(s) required by the included COS libs.
fix: add Cargo as a build dependency
This required in order to build the binary wheel(s) required by the included COS libs.
Version 3 of charmcraft does not allow a run-on stanza that includes 24.04 with other versions, but 2 does. So we install this versions for our Github workflows.
fix: add Cargo as a build dependency to charmcraft.yaml
manadart
force-pushed
the
3.5-into-3.6
branch
from
088ea7d
to
ff4cdf3
Compare
SimonRichardson
approved these changes
Nov 8, 2024
hpidcock
approved these changes
Nov 8, 2024
|
I am concerned about pydantic_core not being built for all architectures. We might need to handle that somehow. |
Yeah, I think we might also have an issue with COS on non-AMD64. I will merge this and do some testing. A good thing for someone to test with an ARM machine, is relating COS-lite to a controller. |
Testing on an old version was vestigial.
Not sure how we ended up with this list of architectures.
manadart
force-pushed
the
3.5-into-3.6
branch
from
ff4cdf3
to
ab25b1f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Merge from 3.5 to bring forward build support for running on 24.04.
A correction to the list of architectures is slipstreamed in.