This repository has been archived by the owner on May 12, 2021. It is now read-only.
Work around the destroy storage error #3769
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
QA: point guiproxy to this branch on staging, destroy a model, the confirmation dialog should mention that also storage will be destroyed, and then it should work. |
hatched
approved these changes
Aug 8, 2018
| return { | ||
| [tagKey]: tags.build(tags.MODEL, id), | ||
| // TODO(frankban): allow for selecting not to destroy storage. | ||
| // This will be available when switching to jujulib. |
There was a problem hiding this comment.
Issue created to track this: #3770
|
Thanks @frankban |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using a new client (jimm) with an old server (like staging) the client returned that error when the deploy-storage key is missing or false in the API request.
See https://github.com/juju/juju/blob/develop/api/modelmanager/modelmanager.go#L390
Fixes #3659 (for now)
We will improve this later, when using the new jujulib.