This repository was archived by the owner on May 12, 2021. It is now read-only.
Upgrade jaaslib to remove the request for revision-info on Charmstore requests.
#4014
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Starting demo at: https://juju-gui-juju-pr-4014.run.demo.haus/ |
nottrobin
reviewed
Aug 12, 2019
| @@ -5382,7 +5387,7 @@ istanbul-reports@^1.5.1: | |||
| dependencies: | |||
| handlebars "^4.0.3" | |||
|
|
|||
| jaaslib@0.5.0, jaaslib@^0.5.0: | |||
| jaaslib@^0.5.0: | |||
There was a problem hiding this comment.
This would suggest something still depends on plain old jaaslib, no?
There was a problem hiding this comment.
yessir the juju-react-components lib does. It's on deck to get an upgrade :D
Good catch 😉
huwshimi
approved these changes
Aug 13, 2019
|
Thanks @huwshimi |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #4013
To QA:
revision-infoin the url.