Add ability to set color capability on loggocolor #34
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I've run across a situation where I would like to force loggocolor to write colors (in this case, writing to a termcap view which implements io.Writer). However, `github.com/juju/ansiterm` does not see this as a terminal - rightly so - so this branch adds a new constructor that calls `ansiterm.SetColorCapable` for the Writer before returning it. It leaves the current API unchanged.
|
Can one of the admins verify this patch? |
howbazaar
approved these changes
Feb 12, 2019
|
|
|
All seems very reasonable to me. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've run across a situation where I would like to force loggocolor to write colors (in this case, writing to a termcap view which implements io.Writer). However,
github.com/juju/ansitermdoes not see this as a terminal - rightly so - so this branch calls `ansiterm.Writer.SetColorCapable before returning loggocolor.Writer in the