Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Find operating system for deploy regardless of juju controller version. #358

Merged
merged 3 commits into from
Dec 7, 2023
Merged

Find operating system for deploy regardless of juju controller version. #358

merged 3 commits into from
Dec 7, 2023

Commits on Dec 6, 2023

  1. Ensure we have a suggested series from resolveCharm. 

    Between juju 2.9 and 3.x, there is a move from using series to base.
This provider client is using the juju 2.9.46 code base for API, but may
be run against 2.9, 3.1.x, 3.3.x controller with the expection that
current functionality will work. Trust the base first as 3.1 may not
return a series in the charm.URL. Fall back is the series from the URL.
    @hmlanigan
    hmlanigan committed Dec 6, 2023
    Configuration menu
    Copy the full SHA
    5418829 View commit details
    Browse the repository at this point in the history

  2. Include juju 3.1/stable when running canary and integration tests. 

    Should have caught issue juju#352 earlier. Increase our testing coverage to
help fill the gap.

Split into 2 test matrices for juju 2.9 & 3.1

Juju 3.1 requires a strictly confined version of the microk8s snap, will
2.9 uses classic. Further splitting of the tests required due to bug in
charmed-kubernetes actions operator, there is not a tag specific for a
microk8s channel.
    @hmlanigan
    hmlanigan committed Dec 6, 2023
    Configuration menu
    Copy the full SHA
    ec94489 View commit details
    Browse the repository at this point in the history

  3. Use matrix include. 

    This solves the problem in the matrix where the channel is only
necessary for microk8s clouds and not lxd. It also allows for 1 test
configuration rather than many..
    @hmlanigan
    hmlanigan committed Dec 6, 2023
    Configuration menu
    Copy the full SHA
    4fdf3e4 View commit details
    Browse the repository at this point in the history