Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(application): handle storage details conversion error #525

Merged
merged 2 commits into from
Jul 15, 2024
Merged

fix(application): handle storage details conversion error #525

merged 2 commits into from
Jul 15, 2024

Commits on Jul 12, 2024

  1. fix(application): handle storage details conversion error 

    - Added error handling for "cannot convert storage details"
  in `applicationsClient.ReadApplication`.
- Improved retry logic for storage readiness in `ReadApplicationWithRetryOnNotFound`.

This commit ensures that the application correctly handles storage conversion errors and retries
appropriately until the storage is ready.
    @anvial
    anvial committed Jul 12, 2024
    Configuration menu
    Copy the full SHA
    185ce0d View commit details
    Browse the repository at this point in the history

  2. fix(application): don't return nil if there's an error 

    Related to juju#520, panic on nil pointer from ReadApplicationWithRetryOnNotFound.
Add IsFatalError func to retry. Allow for known types or "connection
refused" which is intermittent. Doesn't guarentee that everything works
as expected, but doesn't panic either.
    @hmlanigan
    hmlanigan committed Jul 12, 2024
    Configuration menu
    Copy the full SHA
    98952a1 View commit details
    Browse the repository at this point in the history