Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add suggestion to use cache if no depot is detected #41

Merged
merged 7 commits into from
Jan 5, 2024

Conversation

IanButterworth
Copy link
Member

@IanButterworth IanButterworth commented Nov 21, 2023

Closes #40

Adds a suggestion to use julia-actions/cache if no depot is detected.

Screenshot 2023-11-21 at 2 50 00 PM

Can be disabled with ignore-no-cache: true

If this is approved, I'll do the same for julia-runtest (whichever comes first in a run will show the note then create the depot, so we won't end up with double notifications)

Copy link

codecov bot commented Nov 21, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (7c82bcb) 100.00% compared to head (4dde79c) 100.00%.
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff            @@
##              main       #41   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            1         1           
  Lines            2         2           
=========================================
  Hits             2         2           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@IanButterworth IanButterworth marked this pull request as ready for review November 21, 2023 19:51
@IanButterworth IanButterworth requested a review from a team as a code owner November 21, 2023 19:51
action.yml Outdated Show resolved Hide resolved
action.yml Outdated Show resolved Hide resolved
action.yml Outdated Show resolved Hide resolved
action.yml Outdated Show resolved Hide resolved
@ViralBShah
Copy link

I don't think I know enough to review this PR. @DilumAluthge Can we disable the review requirements to make maintenance here easier?

@DilumAluthge
Copy link
Member

I think it's nice to require PR reviews, but I don't feel too strongly either way.

@SaschaMann Thoughts on removing the required reviews?

@ViralBShah
Copy link

The dependabot ones are the annoying ones...

@DilumAluthge
Copy link
Member

I think we can configure Dependbot to auto-approve its own PRs.

action.yml Outdated Show resolved Hide resolved
Copy link
Contributor

@omus omus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@IanButterworth

This comment was marked as resolved.

@IanButterworth IanButterworth merged commit 90dd6f2 into main Jan 5, 2024
32 checks passed
@IanButterworth IanButterworth deleted the ib/no_cache_notice branch January 5, 2024 19:39
@ViralBShah
Copy link

Can we set up dependabot to approve its own PRs?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Detect if no depot and recommend julia-actions/cache
4 participants