Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Avoid delay after package registration by cloning General #6

Merged
merged 3 commits into from
Sep 9, 2020
Merged

Avoid delay after package registration by cloning General #6

merged 3 commits into from
Sep 9, 2020

Conversation

tkf
Copy link
Contributor

@tkf tkf commented Sep 9, 2020 •
edited
Loading

This PR applies the workaround julia-actions/julia-runtest#17 to julia-buildpkg.

See tkf/Baselet.jl#16 for an example.

@tkf
Copy link
Contributor Author

tkf commented Sep 9, 2020

It works now (69c8e5e) https://github.com/tkf/Baselet.jl/pull/16/checks?check_run_id=1092742180#step:4:2

@DilumAluthge
Copy link
Member

@StefanKarpinski give it a quick glance and make sure it looks right

SaschaMann
SaschaMann approved these changes Sep 9, 2020
View reviewed changes
Copy link
Member

@SaschaMann SaschaMann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's include the explanations here too

action.yml Outdated Show resolved Hide resolved
action.yml Show resolved Hide resolved
@tkf @SaschaMann
Copy the full comments from julia-runtest
e7c1b1b 
Co-authored-by: Sascha Mann <git@mail.saschamann.eu>
@tkf
Copy link
Contributor Author

tkf commented Sep 9, 2020

Run with e7c1b1b: https://github.com/tkf/Baselet.jl/pull/16/checks?check_run_id=1092795483#step:4:2

@DilumAluthge
Copy link
Member

@SaschaMann go ahead and merge and tag when you feel this is ready

@SaschaMann SaschaMann merged commit 74a86a5 into julia-actions:master Sep 9, 2020
@SaschaMann
Copy link
Member

Done, thanks all :)

@tkf tkf deleted the latency branch September 9, 2020 20:01
@c42f c42f mentioned this pull request Oct 19, 2020
Closed
@KristofferC KristofferC mentioned this pull request Jun 7, 2021
Closed
@oxinabox oxinabox mentioned this pull request Aug 18, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SaschaMann SaschaMann SaschaMann approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tkf @DilumAluthge @SaschaMann