-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add test_arg input and populate to test_args in test() #73
Add test_arg input and populate to test_args in test() #73
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #73 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 1 1
Lines 2 2
=========================================
Hits 2 2 ☔ View full report in Codecov by Sentry. |
Is there anything blocking the PR? I would also find the functionality helpful. I see the in #39 there was a concern about adding too many additional keyword args, but this seems like a very basic piece of functionality. |
I would also find this functionality useful, thanks for filing the PR! |
2c59dc1
to
2f62631
Compare
I rebased my changes on the current main branch. Hopefully, this gives another impuls for a review of this PR. |
I would very much like to see this merged, Could we get this to support multiple |
Thanks @mhauru for your comment. Yes, I am totally fine if you add/amend to my PR. To be honest, I am a little bit reluctant to put to much effort in this PR by myself. This PR is open for quite a while. But the maintainers did not find the time for a review. |
Sorry your PR was opened in a period of low maintenance and it fell down in attention. Please feel free to bump when the PR is considered ready again for review/merge. |
2f62631
to
6078bf7
Compare
Thanks @IanButterworth for your comment! I rebased my proposed changes on the latest main branch. From my perspective this PR is ready for review. Could you have a look? I would suggest to first integrate this PR and then @mhauru could add support for multiple arguments. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this could do with an example in the readme
Documentation and example is a fair point. I just added a paragraph to the readme. @IanButterworth, could you have a look if this works for you? |
@mhauru please go ahead and PR the multiple args work and we can make a release after that |
This PR aims at increasing flexibility for running Julia tests. The string value of the new test_arg input is passed to test and can be accessed in Julia via the ARGS variable.
Use cases are, for example, distinuishing runs of fast and slow tests.