Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Only allow download URLs pointing at the official S3 URL #52

Closed
SaschaMann opened this issue Dec 3, 2020 · 0 comments · Fixed by #71
Closed

Only allow download URLs pointing at the official S3 URL #52

SaschaMann opened this issue Dec 3, 2020 · 0 comments · Fixed by #71
Assignees
@SaschaMann
Labels
enhancement New feature or request security

Comments

@SaschaMann
Copy link
Member

Currently the install script trusts versions.json completely. It would be good to have at least some precautions in case that file is compromised, like only accepting download URLs starting with https://julialang-s3.julialang.org/bin/.

This line needs to be changed:

setup-julia/src/installer.ts

Line 134 in 2bf5fd1

return fileInfo.url

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@SaschaMann SaschaMann

Labels
enhancement New feature or request security
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Only allow download URLs pointing at the official S3 URL julia-actions/setup-julia
1 participant
@SaschaMann