Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pin node version to v16. Fix #135 #145

Merged
merged 1 commit into from
Feb 26, 2023
Merged

Conversation

sunoru
Copy link
Contributor

@sunoru sunoru commented Feb 24, 2023

Run the builds with Node v16 since v18 is the default on github action runners now (actions/runner-images#7002). It will fix #135.

We can remove these lines whenever using: node18 is available: https://docs.github.com/en/actions/creating-actions/metadata-syntax-for-github-actions#runsusing-for-javascript-actions

@sunoru sunoru requested a review from a team as a code owner February 24, 2023 16:57
@sunoru sunoru changed the title Pin node version to v16. Pin node version to v16. Fix #135 Feb 24, 2023
@DilumAluthge
Copy link
Member

What about users of this action? Do they need to do something to make sure that when they use the setup-julia action, that Node 16 will be used?

@sunoru
Copy link
Contributor Author

sunoru commented Feb 24, 2023

No, they won't be affected at all. setup-julia always uses node v16 in users' actions as defined here

The issue of github defaulting to node v18 only caused our "Example builds" under this repo to fail.

Copy link
Member

@SaschaMann SaschaMann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you

@SaschaMann SaschaMann enabled auto-merge (squash) February 26, 2023 17:32
@SaschaMann SaschaMann disabled auto-merge February 26, 2023 17:33
@SaschaMann SaschaMann merged commit 90d78ec into julia-actions:master Feb 26, 2023
@sunoru sunoru deleted the patch-1 branch February 26, 2023 18:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Test builds are failing (except on macOS)
3 participants