Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix set_variable for globals #11

Merged
merged 2 commits into from
Jul 6, 2020
Merged

fix set_variable for globals #11

merged 2 commits into from
Jul 6, 2020

Conversation

pfitzseb
Copy link
Member

@pfitzseb pfitzseb commented Jul 6, 2020 •
edited
Loading

I forgot about this in #9, so set_variable requests throw an error when trying to modify a global. This PR implements the missing logic.

@pfitzseb pfitzseb added the bug Something isn't working label Jul 6, 2020
@pfitzseb pfitzseb added this to the Next extension patch release milestone Jul 6, 2020
@pfitzseb pfitzseb requested a review from davidanthoff July 6, 2020 07:33
@pfitzseb pfitzseb self-assigned this Jul 6, 2020
@davidanthoff davidanthoff merged commit b7c8d11 into master Jul 6, 2020
@davidanthoff davidanthoff deleted the sp/fixsetvarforglobals branch July 6, 2020 17:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@davidanthoff davidanthoff davidanthoff approved these changes

Assignees

@pfitzseb pfitzseb

Labels
bug Something isn't working
Projects
None yet
Milestone
Next Bugfix Release
Development

Successfully merging this pull request may close these issues.
2 participants
@pfitzseb @davidanthoff