Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set SOURCE_PATH for the correct task #12

Merged
merged 1 commit into from
Jul 10, 2020
Merged

Set SOURCE_PATH for the correct task #12

merged 1 commit into from
Jul 10, 2020

Conversation

davidanthoff
Copy link
Member

I forgot to adjust this when I moved things to a two task model. So what happens in the currently shipping version is that no include statement with a relative path works in the F5 mode... This fixes things.

I think we should try to push out a patch release ASAP with this, so as soon as someone has reviewed this I'll release an insider release with this and then hopefully to everyone soon after.

Fixes https://discourse.julialang.org/t/vs-code-debugger-include-bar-jl-paused-on-exception/42779.

@davidanthoff davidanthoff added the bug Something isn't working label Jul 10, 2020
@davidanthoff davidanthoff self-assigned this Jul 10, 2020
Copy link
Member

@pfitzseb pfitzseb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Copy link
Member

@aviatesk aviatesk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, by the way, can't we use

task_local_storage(:SOURCE_PATH, path) do
   ...
end

?
then we only need to modify debugger_requests.jl, I think

@davidanthoff davidanthoff merged commit b6d9245 into master Jul 10, 2020
@davidanthoff davidanthoff deleted the fix-path branch July 10, 2020 19:48
@davidanthoff
Copy link
Member Author

I don't think we can use the anonymous function version because we want to change the value across messages, right?

@oppo-source oppo-source removed the request for review from a team April 16, 2021 07:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants